Fixed Resource Leak In Point Cloud Example #14185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a resource leak in the C# Point Cloud documentation example by properly disposing of intermediate frame objects created during point cloud processing.
- Separates the
pc.Process(depth)call from theAs<Points>()cast to ensure both objects are properly disposed - Adds proper
usingstatement for the intermediate frame object to prevent resource leaks
Comments suppressed due to low confidence (1)
wrappers/csharp/Documentation/cookbook.md:284
- [nitpick] The variable name 'frame' is too generic. Consider using a more descriptive name like 'processedFrame' or 'pointCloudFrame' to clarify that this is the result of point cloud processing.
using (var frame = pc.Process(depth))
Nir-Az
reviewed
Aug 13, 2025
| using (var frames = pipe.WaitForFrames()) | ||
| using (var depth = frames.DepthFrame) | ||
| using (var points = pc.Process(depth).As<Points>()) | ||
| using (var frame = pc.Process(depth)) |
Collaborator
There was a problem hiding this comment.
Thanks for the PR !
I suggest to rename frame to pc_frame
Thoughts?
Renamed frame to pc_frame (review feedback)
Nir-Az
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this example for point clouds led to a resource leak.
As documented in the section on casting:
Fixed this.