Skip to content

Conversation

@OhadMeir
Copy link
Contributor

Tracked by [RSDSO-20133]

@OhadMeir OhadMeir requested review from Nir-Az and Copilot March 31, 2025 18:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new example for on-chip calibration to demonstrate how to activate internal calibrations on a RealSense device.

  • A new "rs-on-chip-calib" example file (readme.md) is introduced with code snippets and usage instructions.
  • Example lists in both examples/readme.md and examples/depth.md are updated to include the new calibration example.

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.

File Description
examples/readme.md Added an entry for the On Chip Calibration example.
examples/on-chip-calib/readme.md New file providing example overview and code usage for on-chip calibration.
examples/depth.md Added an entry for the On Chip Calibration example.
Files not reviewed (3)
  • examples/CMakeLists.txt: Language not supported
  • examples/on-chip-calib/CMakeLists.txt: Language not supported
  • examples/on-chip-calib/rs-on-chip-calib.cpp: Language not supported

@OhadMeir OhadMeir requested review from Copilot and removed request for Nir-Az March 31, 2025 18:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an example for on-chip calibration using RealSense devices and updates related readme files to reference this new example.

  • Added a new readme for the rs-on-chip-calib example.
  • Updated the examples/readme.md and examples/depth.md files to include a new row linking to the on-chip calibration example.

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
examples/readme.md Added a new table row linking to the on-chip calibration example.
examples/on-chip-calib/readme.md New documentation outlining the on-chip calibration example details.
examples/depth.md Updated to include the on-chip calibration example in the list.
Files not reviewed (3)
  • examples/CMakeLists.txt: Language not supported
  • examples/on-chip-calib/CMakeLists.txt: Language not supported
  • examples/on-chip-calib/rs-on-chip-calib.cpp: Language not supported

Copy link

@jzhao80 jzhao80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, we might want to enhance it later with other calibrations like tare and FL, what do you think?

@OhadMeir
Copy link
Contributor Author

OhadMeir commented Apr 1, 2025

Looks great overall, we might want to enhance it later with other calibrations like tare and FL, what do you think?

Thanks.
I chose OCC because Tare and FL need special targets/settings and are harder to do correctly in a short CLI example. Flow is same but if not done correctly it will result in bad calibration.

@OhadMeir OhadMeir merged commit a1aa583 into realsenseai:development Apr 2, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants