-
Notifications
You must be signed in to change notification settings - Fork 5k
Add rs-on-chip-calib example #13902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rs-on-chip-calib example #13902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new example for on-chip calibration to demonstrate how to activate internal calibrations on a RealSense device.
- A new "rs-on-chip-calib" example file (readme.md) is introduced with code snippets and usage instructions.
- Example lists in both examples/readme.md and examples/depth.md are updated to include the new calibration example.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/readme.md | Added an entry for the On Chip Calibration example. |
| examples/on-chip-calib/readme.md | New file providing example overview and code usage for on-chip calibration. |
| examples/depth.md | Added an entry for the On Chip Calibration example. |
Files not reviewed (3)
- examples/CMakeLists.txt: Language not supported
- examples/on-chip-calib/CMakeLists.txt: Language not supported
- examples/on-chip-calib/rs-on-chip-calib.cpp: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an example for on-chip calibration using RealSense devices and updates related readme files to reference this new example.
- Added a new readme for the rs-on-chip-calib example.
- Updated the examples/readme.md and examples/depth.md files to include a new row linking to the on-chip calibration example.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/readme.md | Added a new table row linking to the on-chip calibration example. |
| examples/on-chip-calib/readme.md | New documentation outlining the on-chip calibration example details. |
| examples/depth.md | Updated to include the on-chip calibration example in the list. |
Files not reviewed (3)
- examples/CMakeLists.txt: Language not supported
- examples/on-chip-calib/CMakeLists.txt: Language not supported
- examples/on-chip-calib/rs-on-chip-calib.cpp: Language not supported
jzhao80
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Nir-Az
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, we might want to enhance it later with other calibrations like tare and FL, what do you think?
Thanks. |
Tracked by [RSDSO-20133]