add unifi switch to libci #13895
Merged
add unifi switch to libci #13895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Apr 1, 2025
| usage() | ||
| # See the end of the file for all the option handling | ||
|
|
||
| # we assume that if paramiko is not installed, unifi is not in use |
Collaborator
There was a problem hiding this comment.
Please also add to the wiki what should be pip installed
Nir-Az
reviewed
Apr 1, 2025
unit-tests/py/rspy/unifi.py
Outdated
| self.client = discover() # assuming no throw because it's done in the c'tor | ||
|
|
||
| if reset: | ||
| log.w("reset flag passed to unifi switch, ignoring it") # rebooting the switch takes a long time, over a minute |
Collaborator
There was a problem hiding this comment.
Please say this is comment out because the process takes over a minute
Nir-Az
reviewed
Apr 1, 2025
| def all_ports(self): | ||
| return self.POE_PORTS # usually we only want to work with PoE ports | ||
|
|
||
| def ports(self): |
Collaborator
There was a problem hiding this comment.
Please add functions description like we have on Acroname.
e.g.
"""
:return: a list of all ports currently occupied (and enabled)
"""
Nir-Az
reviewed
Apr 1, 2025
|
|
||
| def _create_unifi(): | ||
| try: | ||
| from rspy import unifi |
Collaborator
There was a problem hiding this comment.
We have 2 places with this hard coded data, please define it in 1 place and use on both
Nir-Az
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on: [LRS-1223]