Feature/ashraf/lib cicd #13894
Merged
Feature/ashraf/lib cicd #13894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Mar 30, 2025
unit-tests/run-unit-tests.py
Outdated
| print( ' --device <> Run only on the specified devices; ignore any test that does not match (implies --live)' ) | ||
| print( ' --no-reset Do not try to reset any devices, with or without a hub' ) | ||
| print( ' --hub-reset If a hub is available, reset the hub itself' ) | ||
| print( ' --custom-fw If custom fw provided flash it if its different that the current fw installed' ) |
Nir-Az
reviewed
Mar 30, 2025
| image_file = find_image_or_exit(product_name) if not custom_fw_path else custom_fw_path | ||
| cmd = [fw_updater_exe, '-r', '-f', image_file] | ||
| if custom_fw_path: | ||
| # unsiged fw |
Nir-Az
reviewed
Mar 30, 2025
unit-tests/test-fw-update.py
Outdated
| if recovered or 'nightly' not in test.context: | ||
| if recovered or 'nightly' not in test.context or custom_fw_path: | ||
| # In nightly, we always update; otherwise we try to save time, so do not do anything! | ||
| # If custom fw was provided always update for now. |
Collaborator
There was a problem hiding this comment.
At the libci param description you wrote
'If custom fw provided flash it if its different that the current fw installed'
Why not implementing it?
acb1aaa to
7a630e2
Compare
7a630e2 to
e28eebb
Compare
Nir-Az
reviewed
Mar 30, 2025
| no_reset = False | ||
| hub_reset = False | ||
| skip_disconnected = False | ||
| custom_fw_path='' |
Nir-Az
reviewed
Mar 30, 2025
unit-tests/test-fw-update.py
Outdated
| filename = os.path.basename(file_path) | ||
| match = re.search(r'Image(\d+)_(\d+)_(\d+)_(\d+)', filename) | ||
| if match: | ||
| return rsutils.version(".".join(match.groups()[:3])) # Skip the last digit |
Collaborator
There was a problem hiding this comment.
But the last digit is not always 0, right?
Contributor
Author
There was a problem hiding this comment.
what happens when the last digit is not 0?
will the fw version include the last digit ? cause i saw that currently it doesn't and it shows only 5.7.6 not 5.7.6.0
Contributor
Author
There was a problem hiding this comment.
updated to skip last digits only if its zero
6c160ad to
8255e40
Compare
8255e40 to
55f0e76
Compare
Nir-Az
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom fw install