Add D555 IMU extrinsics info #13827
Merged
Add D555 IMU extrinsics info #13827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Mar 10, 2025
| @@ -0,0 +1,57 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
| # Copyright(c) 2022-4 Intel Corporation. All Rights Reserved. | |||
Collaborator
There was a problem hiding this comment.
Maybe we can rename the test name to test-imu.py?
Currently the full name is has 2 extrinsics
found test-live-extrinsics-imu-extrinsics
Nir-Az
reviewed
Mar 10, 2025
| if device_name.find( "D457" ) != -1: | ||
| expected_translation = [-0.09529999643564224, -0.000560000014957041, 0.017400000244379044] | ||
| if device_name.find( "D555" ) != -1: | ||
| expected_translation = [-0.03739999979734421, 0.007189999800175428, 0.022299999371170998] |
Collaborator
There was a problem hiding this comment.
Where do we get this amount of digits? we set less no?
Contributor
Author
There was a problem hiding this comment.
Yes, we set less, but float values are not exact. This is the python float precision. You can get even more precision using float calculators like https://www.h-schmidt.net/FloatConverter/IEEE754.html
Nir-Az
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-3140]