fixed memory leak + add Valgrind memleak GHA test #13772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Nir-Az merged 3 commits into realsenseai:development from gilpazintel:memory_leaks_LRS_317

Mar 4, 2025

Contributor

gilpazintel commented Feb 18, 2025

tracked by LRS-317

gilpazintel requested a review from Nir-Az

February 18, 2025 08:08

Contributor Author

gilpazintel commented Feb 18, 2025

attached 2 files of the tool report

mem leak after fix.txt
mem leak initial state.txt

Collaborator

Nir-Az commented Feb 18, 2025

Can we add the UT in this PR?
Meaning it will fail before the fix and pass with the fix?
(if no other issues raise)

gilpazintel removed the request for review from Nir-Az

February 24, 2025 10:25

gilpazintel marked this pull request as draft

February 24, 2025 15:02

gilpazintel closed this

gilpazintel reopened this

gilpazintel closed this

gilpazintel reopened this

gilpazintel closed this

gilpazintel reopened this

gilpazintel marked this pull request as ready for review

March 2, 2025 12:32

gilpazintel requested a review from Nir-Az

March 2, 2025 12:32

Nir-Az reviewed

View reviewed changes

.github/workflows/memory-leaks-check/CMakeLists.txt Outdated Show resolved Hide resolved

Nir-Az reviewed

View reviewed changes

.github/workflows/memory-leaks-check/CMakeLists.txt Outdated Show resolved Hide resolved

Nir-Az reviewed

View reviewed changes

.github/workflows/memory-leaks-check/start-camera-for-mem-leak.cpp Outdated Show resolved Hide resolved

Nir-Az reviewed

View reviewed changes

.github/workflows/memory-leaks-check/CMakeLists.txt Outdated Show resolved Hide resolved

Nir-Az reviewed

View reviewed changes

.github/workflows/memory-leaks-check/CMakeLists.txt Outdated Show resolved Hide resolved

Nir-Az reviewed

View reviewed changes

.github/workflows/memory-leaks-check/mem-leak-test.cpp Outdated Show resolved Hide resolved

Nir-Az reviewed

View reviewed changes

.github/workflows/memory-leaks-check/mem-leak-test.cpp Outdated Show resolved Hide resolved

Collaborator

Nir-Az commented Mar 2, 2025

Can you please squash your commits?
It's 49 commits with no meaningful names

Nir-Az closed this

Nir-Az reopened this

Nir-Az reviewed

View reviewed changes

.github/workflows/static_analysis.yaml Outdated

               #---------------------------------------------------------------------------------------------------#
+                ValgrindCheck:
+                  name: Valgrind Memory Leak Check
+                  runs-on: ubuntu-22.04

Collaborator

Nir-Az Mar 2, 2025

let's use ubuntu-latest if possible

gilpazintel marked this pull request as draft

March 3, 2025 07:33


          add valgrind memory check to CI. GHA.

44958c5

generate image randomly. remove unneeded references

gilpazintel force-pushed the memory_leaks_LRS_317 branch from 3c702d0 to 44958c5 Compare

March 3, 2025 13:14


          update to ubuntu-latest

069c29e

gilpazintel marked this pull request as ready for review

March 3, 2025 14:06

Nir-Az changed the title ~~fixed memory leak~~ fixed memory leak + add Valgrind memleak GHA test


          remove RSUSB back-end to reduce test duration.

ef144b3

Nir-Az approved these changes

View reviewed changes

Collaborator

Nir-Az left a comment

LGTM

Nir-Az merged commit e315687 into realsenseai:development

25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet