Skip to content

Conversation

@OhadMeir
Copy link
Contributor

Tracked on [RSDEV-2612]

Format is "mono16" to be ROS compatible. Added processing block to handle 10bit data scale to 16bit.
Renamed y16i-to-y10msby10msb to y16i-10msb-to-y16y16.

@OhadMeir OhadMeir requested a review from remibettan January 23, 2025 06:42
// License: Apache 2.0. See LICENSE file in root directory.
// Copyright(c) 2022 Intel Corporation. All Rights Reserved.

#include "y16_10msb-to-y16.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file's name is weird: you have half "_" and half "-".
Besides that, you chose to rename to y16i_10msb_to_y16y16 - so one "y16 is missing in the file's name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the _ in the file name.
There are two files, existing that converts interleaved y16i to two y16 streams and was renamed. Plus a new file that handles one y16 stream with 10 bit data and scales it to 16 bit data.

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OhadMeir OhadMeir merged commit c0b18f2 into realsenseai:development Jan 23, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants