Update ImGui v1.90.9 #13392
Merged
Update ImGui v1.90.9 #13392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Collaborator
|
Note that once ready we will have to make a UI sanity to this change. |
5ea88b8 to
48807d1
Compare
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
b1881af to
dd72548
Compare
844ac13 to
54a0dc3
Compare
Nir-Az
reviewed
Nov 20, 2024
79ed478 to
86d8f64
Compare
86d8f64 to
4ed121d
Compare
Nir-Az
reviewed
Nov 27, 2024
Nir-Az
reviewed
Nov 27, 2024
Nir-Az
reviewed
Nov 27, 2024
Nir-Az
reviewed
Nov 27, 2024
Nir-Az
reviewed
Nov 27, 2024
00a7344 to
41a586b
Compare
Nir-Az
reviewed
Dec 8, 2024
common/device-model.cpp
Outdated
| if (ImGui::ButtonEx(record_button_name.c_str(), device_panel_icons_size, (disable_record_button_logic(is_streaming, is_playback_device)) ? ImGuiButtonFlags_Disabled : 0)) | ||
| bool button_disabled = disable_record_button_logic(is_streaming, is_playback_device); | ||
| if (button_disabled) | ||
| ImGui::PushStyleColor(ImGuiCol_Text,ImVec4(0.5f,0.5f,0.5f,1.f)); |
Contributor
Author
There was a problem hiding this comment.
the flag ImGuiButtonFlags_Disabled was removed so I used ImGuiItemFlags_Disabled flag instead and it wasn't changing the button color (to dark gray). I searched more and found ImGui::BeginDisabled() function that does it better and used it instead.
Nir-Az
reviewed
Dec 8, 2024
common/device-model.cpp
Outdated
| if (button_disabled) | ||
| ImGui::PushStyleColor(ImGuiCol_Text,ImVec4(0.5f,0.5f,0.5f,1.f)); | ||
|
|
||
| if (ImGui::ButtonEx(record_button_name.c_str(), device_panel_icons_size, (disable_record_button_logic(is_streaming, is_playback_device)) ? ImGuiItemFlags_Disabled : 0)) |
Collaborator
There was a problem hiding this comment.
We already have it on button_disabled no?
a64e4a3 to
c6188ef
Compare
Nir-Az
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traced on: [LRS-1129]