-
Notifications
You must be signed in to change notification settings - Fork 5k
linux v4l2 backend - method get_devname_from_video_path efficiency improved #13296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux v4l2 backend - method get_devname_from_video_path efficiency improved #13296
Conversation
src/linux/backend-v4l2.cpp
Outdated
| if (!uevent_file) | ||
| std::string devname; | ||
| bool for_dfu = true; | ||
| if (get_devname_from_video_path(real_path, devname, for_dfu)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not necessarily needed - after all - we append /dev/:
auto mipi_dfu_chardev = "/dev/" + dfu_device_path;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great - thanks
dmipx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
|
URGENT—broke production librealsense in unprivileged containers This PR undid the work of #11900 to make librealsense usable in unprivileged containers, and since being backported to Jazzy has broken our prod. What was this PR in aid of? What efficiency improvements did it provide? Can it be reverted ASAP? |
@ciandonovan Sorry for the inconvenience, and for the hard work that was done by you and got changed later on. For now I can suggest you to pin point 2.55.1 / 4.55.1 versions on your build in order to keep your system stable and allow us time to investigate and solve the issue properly. |
Tracked by: RSDSO-19712