Reuse context from 'find_first_device_or_exit()' & hw reset test stability improvment #13177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jul 22, 2024
|
|
||
| ctx = rs.context() | ||
| device = test.find_first_device_or_exit(); | ||
| device, ctx = test.find_first_device_or_exit(); |
Collaborator
There was a problem hiding this comment.
Please try using this when not using both params.
Nir-Az
reviewed
Jul 22, 2024
| dev, ctx = test.find_first_device_or_exit() | ||
| ctx.set_devices_changed_callback( device_changed ) | ||
| log.out( "Sending HW-reset command" ) | ||
| time.sleep(1) |
Collaborator
There was a problem hiding this comment.
Please shift this line about the comment
Something like:
# allowing some time for the system to stabilize
time.sleep(1)
log.out( "Sending HW-reset command" )
dev.hardware_reset()
Nir-Az
reviewed
Jul 22, 2024
|
|
||
| max_dev_enum_time = get_max_enum_rime_by_device( dev ) | ||
| log.out( "Sending HW-reset command" ) | ||
| time.sleep(1) |
Nir-Az
approved these changes
Jul 23, 2024
Contributor
|
We really need to work on our descriptions... |
Contributor
|
What's the sleep for? |
Collaborator
Trying to make the LibCI tests more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on: [LRS-1170]