D500 DFU - cleaning d400 fw update code, avoid stucking of d500 w/o dfu monitoring #12964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
May 27, 2024
Nir-Az
reviewed
May 27, 2024
| void ds_d500_update_device::dfu_manifest_phase(const platform::rs_usb_messenger& messenger, rs2_update_progress_callback_sptr update_progress_callback) const | ||
| { | ||
| // measuring the progress of the writing to flash (when enabled by FW) | ||
| if (!wait_for_manifest_completion(messenger, RS2_DFU_STATE_DFU_MANIFEST, std::chrono::seconds(200), update_progress_callback)) |
Collaborator
There was a problem hiding this comment.
Should we lower the timeout?
This will also be the timeout for D400 devices that only should take several seconds?
Contributor
Author
There was a problem hiding this comment.
The timeout is around 1.5 times the time it takes.
It is not related to the D400 devices, this code is only for D500 devices.
Nir-Az
reviewed
May 27, 2024
Nir-Az
reviewed
May 27, 2024
Nir-Az
approved these changes
May 27, 2024
Collaborator
Nir-Az
left a comment
There was a problem hiding this comment.
LGTM - consider the comments, your call..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-1224 - second PR