Add D500 DFU progress monitoring support #12948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
May 22, 2024
Nir-Az
reviewed
May 22, 2024
Nir-Az
reviewed
May 22, 2024
Nir-Az
reviewed
May 22, 2024
Nir-Az
reviewed
May 22, 2024
Nir-Az
reviewed
May 22, 2024
Nir-Az
reviewed
May 22, 2024
Nir-Az
reviewed
May 23, 2024
Nir-Az
approved these changes
May 26, 2024
Contributor
|
I have to say, I hate PRs like this that do not have a description of what was done... :) |
maloel
reviewed
Jun 6, 2024
| std::stringstream ss; | ||
| ss << "DFU_GETSTATUS called, state is: " << to_string(dfu_state); | ||
| ss << ", iString equals: " << percentage_of_transfer << ", and bwPollTimeOut equals: " << status.bwPollTimeout << std::endl; | ||
| LOG_DEBUG(ss.str().c_str()); |
Contributor
There was a problem hiding this comment.
Why use stringstream here and not just do the output inside the LOG_DEBUG?
Collaborator
Noted, Description updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-1224 ("pre-PR")
This PR allow monitoring the progress of the DFU progress on D500 devices.
This was the progress percentage is real from the FW and represent the actual progress