Add error handling mechanism to D500 #12628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Feb 1, 2024
src/ds/d400/d400-private.cpp
Outdated
| } | ||
|
|
||
|
|
||
| notification d400_notification_decoder::decode( int value ) |
Collaborator
There was a problem hiding this comment.
Cant we have the same classs (common)for d400 + d500 and give it the map at initialization?
Contributor
Author
There was a problem hiding this comment.
I will do it.
I thought that handling might be different for D500 line but currently it doesn't look like it.
Nir-Az
reviewed
Feb 1, 2024
src/ds/d400/d400-private.cpp
Outdated
|
|
||
| notification d400_notification_decoder::decode( int value ) | ||
| { | ||
| if( ds::d400_fw_error_report.find( static_cast< uint8_t >( value ) ) != ds::d400_fw_error_report.end() ) |
Collaborator
There was a problem hiding this comment.
Please make sure it still works on d400 somehow
Contributor
Author
There was a problem hiding this comment.
Verified using dedicated HWMC
Nir-Az
reviewed
Feb 1, 2024
Nir-Az
reviewed
Feb 1, 2024
Nir-Az
approved these changes
Feb 4, 2024
Collaborator
Nir-Az
left a comment
There was a problem hiding this comment.
Approved, let's speak before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-643]
Moved D400 error list from common to d400-private
Added a new list to d500-private, registering needed options in d500 devices.