-
Notifications
You must be signed in to change notification settings - Fork 5k
Remove SKU D465 #12624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SKU D465 #12624
Conversation
| if( node.valid() ) | ||
| { | ||
| //TODO SAMER | ||
| // We take the "unique id" (really, the composite ID used to associate all the devices belonging to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maloel should we change this example comment if we are taking of SKU D465?
(you gave an example about D465 in the lines below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you can leave it if it doesn't bother you :)
|
there are some files that still include old SKUs, for example, DKMS patches, and win7 drivers:
these files includes also old SKUs like L515, T265, etc.. |
IMO, these need to be cleaned but even I hesitated because of the nature of the file. |
ed75231 to
5d6fb6c
Compare
src/ds/d400/d400-nonmonochrome.cpp
Outdated
| if ((_fw_version >= firmware_version("5.5.8.0")) && (!val_in_range(pid, { RS_USB2_PID }))) | ||
| { | ||
| if (!val_in_range(pid, { RS405_PID , RS455_PID, RS465_PID })) | ||
| if (!val_in_range(pid, { RS405_PID })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to remove D455 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.. thanks for catching that, will fix now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and pushed
5d6fb6c to
b625a20
Compare
OhadMeir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me
Tracked in RSDEV-1555