Skip to content

Conversation

@SamerKhshiboun
Copy link
Contributor

Tracked in RSDEV-1555

if( node.valid() )
{
//TODO SAMER
// We take the "unique id" (really, the composite ID used to associate all the devices belonging to
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maloel should we change this example comment if we are taking of SKU D465?
(you gave an example about D465 in the lines below)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you can leave it if it doesn't bother you :)

@SamerKhshiboun
Copy link
Contributor Author

@Nir-Az, @maloel

there are some files that still include old SKUs, for example, DKMS patches, and win7 drivers:
e.g.

  • scripts\realsense-metadata-jammy-master.patch
  • src\win7\drivers\IntelRealSense_D400_series_win7.inf

these files includes also old SKUs like L515, T265, etc..
should we clean this one day also ? or leave it ?

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review January 31, 2024 12:24
@maloel
Copy link
Contributor

maloel commented Jan 31, 2024

these files includes also old SKUs like L515, T265, etc.. should we clean this one day also ? or leave it ?

IMO, these need to be cleaned but even I hesitated because of the nature of the file.
Up to Nir. If we do it, we should do them all together.

if ((_fw_version >= firmware_version("5.5.8.0")) && (!val_in_range(pid, { RS_USB2_PID })))
{
if (!val_in_range(pid, { RS405_PID , RS455_PID, RS465_PID }))
if (!val_in_range(pid, { RS405_PID }))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove D455 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.. thanks for catching that, will fix now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and pushed

Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@SamerKhshiboun SamerKhshiboun merged commit d06f21b into realsenseai:development Feb 7, 2024
@SamerKhshiboun SamerKhshiboun deleted the remove-d465-sku branch June 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants