Fix intrinsics calculation for non BROWN D500 models #12618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
approved these changes
Jan 29, 2024
OhadMeir
reviewed
Jan 29, 2024
| false ); // symmetry not needed for RGB | ||
| bool use_base_intrinsics | ||
| = ( table->rgb_coefficients_table.distortion_model == RS2_DISTORTION_BROWN_CONRADY | ||
| && table->rgb_coefficients_table.reserved[3] == 0 ); |
Contributor
There was a problem hiding this comment.
Maybe add a comment that we use reserved[3] as a flag here to indicate the full distortion module is not really brown but we treat it as such because the HW fixes fisheye distortion.
maloel
reviewed
Jan 29, 2024
maloel
reviewed
Jan 30, 2024
| = ( table->rgb_coefficients_table.distortion_model == RS2_DISTORTION_BROWN_CONRADY | ||
| && table->rgb_coefficients_table.reserved[3] == 0 ); | ||
|
|
||
| auto rect_params = compute_rect_params_from_resolution( |
Contributor
There was a problem hiding this comment.
This doesn't look like clang-format formatting :)
maloel
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the coefficients table is not BROWN, we override it with BROWN parameters.
If we do that we need to remember it for next time as the original table was not brown.
This PR use a reserve place in the table the flag this change for next time we use the intrinsics