Skip to content

Clean up types.h a little #12297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maloel merged 7 commits into from
Oct 15, 2023
Merged

Clean up types.h a little #12297

maloel merged 7 commits into from
Oct 15, 2023

Conversation

@maloel
Copy link
Contributor

@maloel maloel commented Oct 14, 2023 •
edited
Loading

  • simpler hexdump; make sure it listens to std::uppercase
  • remove hexify
  • move make_less_screamy to rsutils
  • librealsense::copy -> std::memcpy
  • fixed couple of things with acroname and devices

Tracked on [LRS-923]

@maloel maloel requested a review from OhadMeir October 14, 2023 16:00
@maloel maloel force-pushed the make-less-screamy branch from 809c426 to 5131412 Compare October 14, 2023 17:47
OhadMeir
OhadMeir reviewed Oct 15, 2023
View reviewed changes
OhadMeir
OhadMeir reviewed Oct 15, 2023
View reviewed changes
OhadMeir
OhadMeir approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 52eb3e6 into realsenseai:development Oct 15, 2023
@maloel maloel deleted the make-less-screamy branch October 15, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maloel @OhadMeir