Deadlock test & unit-test-config now listens to donotrun #12282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remibettan
reviewed
Oct 11, 2023
Contributor
remibettan
left a comment
There was a problem hiding this comment.
Is the aim of the test to check that deadlock occurs?
Regarding the other line in unit-test-config, please explain
Contributor
Author
The aim is to check if the deadlock occurs: if it does, then a timeout will be reached after 12 seconds and the test will fail
See the description... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #12275, this adds the test that was used to reproduce:
Made it only run on the nightly.
Tried with Python, but failed to reproduce.
On the way, made unit-test-config actually pay attention to the
donotrundirectives in our unit-tests (so, for example, nightly tests aren't even build in non-nightly builds).Tracked on [RSDSO-19304]