GHA checking CMake minimal version test #12118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Aug 30, 2023
Nir-Az
reviewed
Aug 30, 2023
Nir-Az
reviewed
Sep 4, 2023
Nir-Az
reviewed
Sep 4, 2023
Nir-Az
reviewed
Sep 4, 2023
Nir-Az
reviewed
Sep 20, 2023
2a293c1 to
d7310c5
Compare
Nir-Az
reviewed
Sep 26, 2023
Nir-Az
reviewed
Sep 26, 2023
Nir-Az
reviewed
Sep 26, 2023
Nir-Az
reviewed
Sep 26, 2023
Nir-Az
reviewed
Sep 26, 2023
Nir-Az
reviewed
Sep 26, 2023
Checkout specific commit Job renamed Comments added
Nir-Az
reviewed
Sep 26, 2023
Nir-Az
reviewed
Sep 26, 2023
We can't compare strings with '<=' (The 'else' statement run in case strings are equals). So I will separately check first '==' after '<'
Nir-Az
reviewed
Oct 1, 2023
Nir-Az
reviewed
Oct 2, 2023
Nir-Az
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-844]