sw-dev profiles work; shorter rs-enum-devs output; use-basic-formats -> format-conversion #12109
Conversation
| rs2_stream fourcc_to_rs2_stream(uint32_t fourcc_format) const; | ||
|
|
||
| protected: | ||
| // Since _profiles is private, we need a way to get the final profiles |
There was a problem hiding this comment.
This is sensor_base, that is, intended to be inherited from.
Why not make the member protected?
There was a problem hiding this comment.
The member is pretty advanced (lazy) and really should be private, I didn't want to make it accessible.
| args.add_argument( '--time', metavar='<seconds>', type=time_arg, default=2, help='seconds to gather devices for (default 2)' ) | ||
| def domain_arg(x): | ||
| t = int(x) | ||
| if t <= 0: |
There was a problem hiding this comment.
Why not check > 232? Same for other script
There was a problem hiding this comment.
copy paste :)
Fixed.
| from argparse import ArgumentParser | ||
| args = ArgumentParser() | ||
| args.add_argument( '--debug', action='store_true', help='enable debug mode' ) | ||
| args.add_argument( '--quiet', action='store_true', help='No output; just the minimum FPS as a number' ) |
There was a problem hiding this comment.
Comment left from FPS script?
| tags.push_back( { RS2_STREAM_COLOR, | ||
| -1, // index | ||
| color_width, color_height, | ||
| ( format_conversion == format_conversion::full ) ? RS2_FORMAT_RGB8 : RS2_FORMAT_YUYV, |
There was a problem hiding this comment.
It would be more readable to have variables color_format / infrared_format and set them in the list above.
| if( ! context ) | ||
| return format_conversion::full; | ||
| std::string const format_conversion( "format-conversion", 17 ); | ||
| std::string const full( "full", 4 ); |
There was a problem hiding this comment.
Why use string only for one option?
There was a problem hiding this comment.
It's reused, I guess.
sensor_baseand split offraw_sensor_base_profilesnow only insensor_base; software_device uses_sw_profilesand no more_raw_rs_profilessensor_interface::get_raw_stream_profiles()RGB8; now all the permutations supported by LibRSraw,basic, orfull(use-basic-formats->format-conversion)rs-enumerate-devicesoutput now aggregates all FPS lines together, so more readableTracked on [LRS-848]