Draw cross in calibration ROI #12105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Aug 14, 2023
|
|
||
| if( draw_cross ) | ||
| { | ||
| glLineStipple( 1, 0x0808 ); |
Contributor
Author
There was a problem hiding this comment.
No, it's a bit mask pattern.
The dashed/dotted lines in GL are called stipples, and you can set a 16 bit mask of the "fill" of each line section.
I have tried several options and this looked best.
Collaborator
Can you add a screenshot in the description? |
Contributor
Author
Done. Didn't know pictures can be added :-) |
Nir-Az
approved these changes
Aug 14, 2023
OhadMeir
pushed a commit
to OhadMeir/librealsense
that referenced
this pull request
Sep 6, 2023
maloel
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawing a cross in ROI during FL calibration and ground truth calculation.
The target is composed from 4 circles, each should be placed in a different quadrant of the frame. The cross helps setting the target correctly.