LibCI enhancement - recycle all ports at start & disable all ports when finish #12078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Jetson had 2 failures,
|
Collaborator
Author
Now it looks better, I added a 3 sec sleep after HW reset before we start the next test (for mipi (port is None) only ) Please review |
maloel
reviewed
Aug 9, 2023
maloel
reviewed
Aug 9, 2023
maloel
reviewed
Aug 9, 2023
maloel
reviewed
Aug 9, 2023
maloel
reviewed
Aug 10, 2023
unit-tests/py/rspy/devices.py
Outdated
| :return: True if all devices have come back online before timeout | ||
| """ | ||
|
|
||
| usb_serial_numbers = {dev.serial_number for dev in _device_by_sn.values() if dev.port is not None and dev.serial_number in serial_numbers} |
Contributor
There was a problem hiding this comment.
This will work.
But seems kind of unneeded since _device_by_sn is already keyed to SNs:
usb_serial_numbers = {sn for sn in serial_numbers if _device_by_sn[sn].port is not None}
This will also throw if given a SN that's invalid. Good IMO.
maloel
approved these changes
Aug 10, 2023
Contributor
maloel
left a comment
There was a problem hiding this comment.
See my one comment for improvement. Otherwise looks good.
69635eb to
00a44ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change 2 behaviors:
When starting LibCI it used to enable all ports and discover the cameras,
If a device port was enabled on the previous run, it stays on.
If it failed and even the FW crashed on last run, this device will not be discovered in the next run as it's port is already on and the FW crashed.
Now we will always start from a fresh power cycle of the device
When LibCI finish, disable all ports.
No need to keep devices on between LibCI runs. D585S for example is projecting laser from the moment it get power.
No need for the laser to be on all weekend.
This should extend the HW life