Skip to content

Conversation

@maloel
Copy link
Contributor

@maloel maloel commented Jun 15, 2023

Windows already does this -- so this does the same in Linux:

  • Puts everything together, so it's easy to find and create artifacts
  • Turns out, cmake --build . --config <> doesn't work in Linux!
    • See here: "For single configuration generators like Makefile Generators ... the configuration is specified at configure time by the CMAKE_BUILD_TYPE variable"
    • So I changed all the GHA runners to use it in Linux/Mac/Android
    • This can default to be empty, so the default is Release
  • Had to change LibCI to expect collaterals in same place as Windows

Plus fixed some warnings on Linux...

Note that this has to be accompanied by additional PRs in other repos for our CI.

Tracked on [LRS-817]

@maloel maloel requested a review from Nir-Az June 15, 2023 05:41
@maloel
Copy link
Contributor Author

maloel commented Jun 15, 2023

@maloel
Copy link
Contributor Author

maloel commented Jun 15, 2023

I'm rerunning libCI (manually) - found an issue with another script.
Note that once all the PRs go in, we have to update all branches with development right away or they likely won't pass libCI or Jenkins builds.

@maloel
Copy link
Contributor Author

maloel commented Jun 18, 2023

@maloel maloel merged commit 8a0f72d into realsenseai:development Jun 18, 2023
@maloel maloel deleted the linux branch June 18, 2023 06:38
maloel added a commit to maloel/librealsense that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants