replace rspy.test abort_on_fail:bool with on_fail:str (ABORT/RAISE/LOG) #11707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Apr 24, 2023
|
|
||
| class Error( RuntimeError ): | ||
| """ | ||
| Raised when an exception is raised on the remote side, unexpectedly so not the same as CheckFailed |
Contributor
There was a problem hiding this comment.
This comment is not clear. What is the remote side and is it enforced that it will raise Error and not some other type (RuntimeError or CheckFailed...)
OhadMeir
reviewed
Apr 24, 2023
| if on_fail == ABORT: | ||
| abort() | ||
| if on_fail == RAISE: | ||
| raise CheckFailed( f'on_fail=RAISE' ) |
Contributor
There was a problem hiding this comment.
Can't we supply a more informative message?
OhadMeir
reviewed
Apr 24, 2023
| device = wait_for_devices( context, only_sw_devices, n=1. )[0] | ||
| sensors = device.sensors | ||
| test.check_equal( len(sensors), 1, abort_if_failed=True ) | ||
| test.check_equal( len(sensors), 1, on_fail=test.RAISE ) |
Contributor
There was a problem hiding this comment.
Who will catch this? How is it different from aborting?
OhadMeir
approved these changes
Apr 24, 2023
Contributor
OhadMeir
left a comment
There was a problem hiding this comment.
After discussion, all issues are clear and OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize
abort_on_failtoon_failacross the board, with more options:RAISEif a check failstest.CheckFailedexceptiontest.closureand translated to a closure-specificon_fail(so a check fails, raised, caught, and the closure decides whether to just log, or abort, re-raise, etc.)LOG, same as beforeABORT