add D415 formats; change YUYV to yuv422_yuy2 for ROS2 #11534
Conversation
| hex << setfill('0') << setw(4) << header->version << dec | ||
| << ", type " << header->table_type << ", size " << header->table_size | ||
| << ", CRC: " << hex << header->crc32); | ||
| //LOG_DEBUG("Loaded Valid Table: version [mjr.mnr]: 0x" << |
There was a problem hiding this comment.
This only prints once the table is loaded.
It can help onvestigate users issues if we know they has a problem parsing there calibration table no?
Why should we start removing debug messeges?
Can you explain where it hurts?
There was a problem hiding this comment.
It's a big block of text that is useless and unreadable, and just gets in the way in normal operation. I don't remember when I ever needed calibration table information. It's very very specific.
I have different ideas about keeping all these debug messages while not hurting output. Let's talk about it separately.
There was a problem hiding this comment.
Also rs-dds-server tool gets the intrinsics information of all profiles and it prints the info for each one. That is a lot of unneeded information.
D415 uses two additional formats that weren't supported before.
For YUY2/YUYV, the equivalent ROS2 format is
yuv422_yuy2, supported since Foxy. This was tested and it works.