rsutils::version, replacing librealsense::firmware_version & sw_update::version #11191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Dec 12, 2022
| test.check( v2.is_between( v1, v3 )) | ||
| test.check( v3.is_between( v1, v3 )) | ||
| test.check( v2.is_between( v2, v3 )) | ||
| test.check( v2.is_between( v2, v2 )) |
Collaborator
There was a problem hiding this comment.
Better to add a state when is_between() failed
Contributor
Author
There was a problem hiding this comment.
Hey, I just took your code from the .cpp :)
Nir-Az
reviewed
Dec 12, 2022
| test.check( not version( 0x100, 0xFFFF, 0xFF, 0xFFFFFFFF )) | ||
| test.check( not version( 0xFF, 0x10000, 0xFF, 0xFFFFFFFF )) | ||
| test.check( not version( 0xFF, 0xFFFF, 0x100, 0xFFFFFFFF )) | ||
| #test.check( not version( 0xFF, 0xFFFF, 0xFF, 0x100000000 )) Python throws - type error |
Nir-Az
reviewed
Dec 12, 2022
| { | ||
| unsigned major = 0; | ||
| char const * ptr = base; | ||
| while( *ptr != '.' ) |
Collaborator
There was a problem hiding this comment.
Please add protection from nullptr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionto pyrsutilsrspy.repo.compare_fw_versions()and.pretty_fw_version()rsutils/string/test-sw-update-ver.cpptest in favor ofrsutils/test-version.pyNote:
A small side-effect of this is that FW versions that were previously expressed as
05.14.00.00will now be5.14.0(the last number is omitted when 0). I've tested a bit (including FW downgrade and upgrade, with rs-fw-update and viewer) and found no issue...