Skip to content

Conversation

@maloel
Copy link
Contributor

@maloel maloel commented Aug 10, 2022

Durations do not have an operator<< unless you're in C++20, so output from test-waiting-on was not readable.
Before:

C:\jenkins_sys_rsbuild\workspace\LRS_windows_compile_pipeline\unit-tests\utilities\time\test-waiting-on.cpp(164): FAILED:
  REQUIRE( wait_time >= timeout )
with expansion:
  {?} >= {?}

After:

with expansion:
  0.005s > 1.99s

@maloel maloel requested a review from Nir-Az August 10, 2022 07:40
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Nir-Az Nir-Az merged commit 31d7702 into realsenseai:development Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants