Fix logic flaw of of shouldInvalidateLayoutForBoundsChange in IGListCollectionViewLayout#1236
Closed
allenhsu wants to merge 2 commits intoInstagram:masterfrom
Closed
Fix logic flaw of of shouldInvalidateLayoutForBoundsChange in IGListCollectionViewLayout#1236allenhsu wants to merge 2 commits intoInstagram:masterfrom
allenhsu wants to merge 2 commits intoInstagram:masterfrom
Conversation
Generated by 🚫 Danger |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
TimOliver
pushed a commit
that referenced
this pull request
Dec 10, 2025
…ollectionViewLayout (#1236) Summary: Issue fixed: #1235 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: #1236 Reviewed By: lorixx Differential Revision: D12839081 Pulled By: rnystrom fbshipit-source-id: 3e9e1192f16912d560d76f3730a377f303708cd7
TimOliver
pushed a commit
that referenced
this pull request
Dec 10, 2025
…ollectionViewLayout (#1236) Summary: Issue fixed: #1235 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: #1236 Reviewed By: lorixx Differential Revision: D12839081 Pulled By: rnystrom fbshipit-source-id: 3e9e1192f16912d560d76f3730a377f303708cd7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #1235
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.