Skip to content

fix: b/219021576 #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 11 commits into from
Feb 22, 2022
Merged

fix: b/219021576 #7473

gcf-merge-on-green merged 11 commits into from
Feb 22, 2022

Conversation

@leahecole
Copy link
Collaborator

@leahecole leahecole commented Feb 17, 2022 •
edited
Loading

Description

Fixes b/219021576, corresponding cl/429403697

Also adds jinja templated variables as best practice as a part of addressing #6555

Airflow 1 successful DAG Run
Airflow 2 successful DAG Run

Note: It's a good idea to open an issue first for discussion.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 17, 2022
@leahecole leahecole marked this pull request as ready for review February 18, 2022 23:26
@leahecole leahecole requested review from a team and rachael-ds as code owners February 18, 2022 23:26
@leahecole leahecole added the blunderbuss: assign Instruct blunderbuss to assign someone label Feb 18, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Feb 18, 2022
@leahecole leahecole requested a review from bradmiro February 18, 2022 23:26
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@leahecole
Copy link
Collaborator Author

leahecole commented Feb 19, 2022

Got my product expert, ready for @engelke now! :)

dandhlee
dandhlee reviewed Feb 22, 2022
View reviewed changes
dandhlee
dandhlee approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit below!

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Feb 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit c042a15 into main Feb 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the b/219021576 branch February 22, 2022 18:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradmiro bradmiro bradmiro approved these changes

@dandhlee dandhlee dandhlee approved these changes

@rachael-ds rachael-ds Awaiting requested review from rachael-ds

@pavel-salnikov pavel-salnikov Awaiting requested review from pavel-salnikov

Assignees

@engelke engelke

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leahecole @bradmiro @dandhlee @engelke @kokoro-team