Skip to content

Conversation

@janlugt
Copy link
Contributor

@janlugt janlugt commented Dec 14, 2016

vm: true is deprecated.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 14, 2016
@janlugt
Copy link
Contributor Author

janlugt commented Dec 14, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 14, 2016
@theacodes
Copy link
Contributor

Thanks, @janlugt - I think the endpoints one was using vm: true for a reason.

@sepehre @kdeus is there any reason the endpoints sample won't work on env: flex?

@janlugt
Copy link
Contributor Author

janlugt commented Dec 14, 2016

I did the quickstart for endpoints this afternoon as part of a review, and gcloud did not accept the config until I changed vm:true to env:flex. I haven't tested the other two files, but I figure it would be the same. It's mentioned in the release notes here: https://cloud.google.com/appengine/docs/flexible/python/release-notes#november_15th_2016

@theacodes
Copy link
Contributor

@janlugt good enough for me, thanks. @sepehre and @kdeus if you chime in with reservations post-merge let me know.

@theacodes theacodes merged commit a683165 into GoogleCloudPlatform:master Dec 14, 2016
@kdeus
Copy link
Contributor

kdeus commented Dec 14, 2016

Sounds fine. Looks like we just hadn't updated this sample to env: flex yet. Thanks!

@sepehre
Copy link
Contributor

sepehre commented Dec 14, 2016

Yes, flex everywhere! Onwards! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants