Skip to content

Conversation

@leahecole
Copy link
Collaborator

@leahecole leahecole commented Apr 13, 2021

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

@leahecole leahecole requested a review from tswast April 13, 2021 21:02
@leahecole leahecole requested a review from a team as a code owner April 13, 2021 21:02
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2021
@leahecole leahecole added the api: composer Issues related to the Cloud Composer API. label Apr 13, 2021
@dandhlee
Copy link
Collaborator

same typo is found in other files: could you also update these?

./composer/rest/get_dag_prefix.py:        'location', help='Region of the Cloud Composer environent.')
./composer/rest/get_dag_prefix.py:        'composer_environment', help='Name of the Cloud Composer environent.')
./composer/rest/get_client_id.py:        'location', help='Region of the Cloud Composer environent.')
./composer/rest/get_client_id.py:        'composer_environment', help='Name of the Cloud Composer environent.')
./composer/rest/README.rst:      location              Region of the Cloud Composer environent.
./composer/rest/README.rst:      composer_environment  Name of the Cloud Composer environent.

@leahecole
Copy link
Collaborator Author

Oh dang @dandhlee good eyes! The README.rst is autogenned but I'll do a find and replace for environent :)

@leahecole
Copy link
Collaborator Author

I fixed the typos in the other file and as an added bonus added two usage comments as a first step for improvement (#5546 )

Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint is slightly unhappy but otherwise LGTM!

@leahecole
Copy link
Collaborator Author

🙈 fixing now

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit be7e622 into master Apr 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the typo-fix branch April 13, 2021 21:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: composer Issues related to the Cloud Composer API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants