-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(firestore): async snippets #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore): async snippets #4454
Conversation
f2def9e to
495ae79
Compare
|
Question: are annotations scoped to the repo, project, or file? I assumed the latter, so snippets tags are shared between sync and async. |
BenWhitehead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @rafilong!!! Thanks for getting all this done.
One thing we need to do is figure out a naming scheme for the async samples so that defsite doesn't union these new samples and the existing ones.
@busunkim96 @crwilcox Do we have a naming schema already defined for async clients and samples?
|
We don't have a pattern yet but I feel like appending async to the region tag makes sense as it would group with the other sample. Still haven't settled on how to display these though. For instance, should they both show under python or do we want a new Python (async) tab similar to how Java has the Android version. Either way we need to settle on a new region tag. How are the Android ones separated? |
|
It looks like in Android the java/kotlin separation is handled by the sample registry indirection (though I'm not familiar with how that actually works). I'm okay with having an |
|
@BenWhitehead @crwilcox would adding an |
|
Adding the |
|
@BenWhitehead @crwilcox suffix added! |
Add snippets for new async Firestore interface. Snippets are ported from
firestore/cloud-clienttofirestore/cloud-async-client.