Skip to content

Fix Endpoints Bookstore YAML #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
engelke merged 2 commits into from
Dec 6, 2018
Merged

Fix Endpoints Bookstore YAML #1902

engelke merged 2 commits into from
Dec 6, 2018

Conversation

@daniel-sanche
Copy link
Member

@daniel-sanche daniel-sanche commented Dec 5, 2018

addressing this issue: #1129 (comment)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2018
@daniel-sanche daniel-sanche mentioned this pull request Dec 5, 2018
Closed
@daniel-sanche daniel-sanche added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 5, 2018
engelke
engelke approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit bab6c41 into master Dec 6, 2018
@jmdobry jmdobry deleted the endpoints_yaml_fix branch December 14, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sanche @engelke @googlebot