Skip to content

Bug fixes. #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelawyu merged 2 commits into from
Nov 6, 2018
Merged

Bug fixes. #1820

michaelawyu merged 2 commits into from
Nov 6, 2018

Conversation

@michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented Nov 6, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2018
@michaelawyu michaelawyu requested a review from ace-n November 6, 2018 23:07
ace-n
ace-n approved these changes Nov 6, 2018
View reviewed changes
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you've tested it

@michaelawyu michaelawyu merged commit c0006c8 into master Nov 6, 2018
@alixhami alixhami deleted the michaelawyu-patch-2 branch November 9, 2018 18:39
@engelke engelke mentioned this pull request Dec 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ace-n ace-n ace-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelawyu @ace-n @googlebot