Skip to content

Conversation

@alixhami
Copy link
Contributor

@alixhami alixhami commented Nov 1, 2018

No description provided.

@alixhami alixhami requested a review from tswast November 1, 2018 17:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: DPEBot will likely strip out these region tags next time there's a client library version bump. You might want to have a separate directory for the pandas-gbq sample so that you can include the whole file without getting the datalab stuff.

Copy link
Contributor Author

@alixhami alixhami Nov 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. I made the directory specific to pandas-gbq and put all the samples in one file. It'll be easier to maintain with all of them in one file, plus they both need the same fixture for temporary datasets.

@alixhami alixhami merged commit b4f6649 into master Nov 5, 2018
@alixhami alixhami deleted the migration-guide branch November 5, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants