-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Fix SQL query to return 10 rows & simplify #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PicardParis
commented
Jul 31, 2017
- Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results)
- Standard SQL specified directly in query
- Removed parameter max_results to avoid redundancy w/ query
- Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results) - Standard SQL specified directly in query - Removed parameter max_results to avoid redundancy w/ query
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Added my corporate email in GitHub settings |
|
CLAs look good, thanks! |
tswast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
@tswast @PicardParis This caused the system tests to fail. Can one of you send a PR to update the tests? |
|
Proposed change still gets a PASSED: Failures are related to 2 other tests. |
|
@PicardParis thanks! |
…CloudPlatform/python-docs-samples#1041) - Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results) - Standard SQL specified directly in query - Removed parameter max_results to avoid redundancy w/ query
…CloudPlatform/python-docs-samples#1041) - Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results) - Standard SQL specified directly in query - Removed parameter max_results to avoid redundancy w/ query
…orm/python-docs-samples#1041) - Original query returned a single nested row (instead of 10 rows as apparently expected in section print_results) - Standard SQL specified directly in query - Removed parameter max_results to avoid redundancy w/ query