Skip to content

fix: support 'localtime' as a timezone - #625

Merged
olavloite merged 2 commits into
postgresql-dialectfrom
timezone-localtime
Feb 10, 2023
Merged

olavloite merged 2 commits into
postgresql-dialectfrom
timezone-localtime

Conversation

@olavloite

Copy link
Copy Markdown
Collaborator

Add support for the localtime timezone.

Fixes #611

@codecov

codecov Bot commented Jan 31, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #625 (d14d7cb) into postgresql-dialect (6ef7240) will increase coverage by 2.63%.
The diff coverage is 96.53%.

❗ Current head d14d7cb differs from pull request most recent head dae9126. Consider uploading reports for the commit dae9126 to get more accurate results

@@                   Coverage Diff                    @@
##             postgresql-dialect     #625      +/-   ##
========================================================
+ Coverage                 86.32%   88.96%   +2.63%     
- Complexity                 1914     2172     +258     
========================================================
  Files                       122      125       +3     
  Lines                      6216     7211     +995     
  Branches                    849     1033     +184     
========================================================
+ Hits                       5366     6415    +1049     
+ Misses                      605      558      -47     
+ Partials                    245      238       -7     
Flag Coverage Δ
all_tests 88.96% <96.53%> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/cloud/spanner/pgadapter/utils/PgJdbcCatalog.java 0.00% <ø> (ø)
...panner/pgadapter/wireprotocol/PasswordMessage.java 67.34% <ø> (ø)
.../cloud/spanner/pgadapter/utils/MutationWriter.java 92.88% <78.37%> (+2.50%) ⬆️
...gle/cloud/spanner/pgadapter/error/PGException.java 90.62% <85.71%> (+0.96%) ⬆️
...r/pgadapter/statements/SessionStatementParser.java 75.70% <85.71%> (-0.60%) ⬇️
...gle/cloud/spanner/pgadapter/ConnectionHandler.java 87.25% <86.66%> (-0.25%) ⬇️
...oud/spanner/pgadapter/parsers/TimestampParser.java 90.42% <89.79%> (-2.80%) ⬇️
...panner/pgadapter/wireprotocol/DescribeMessage.java 85.50% <90.00%> (-0.61%) ⬇️
.../spanner/pgadapter/statements/VacuumStatement.java 91.42% <91.42%> (ø)
...oud/spanner/pgadapter/statements/SimpleParser.java 92.30% <92.15%> (+0.96%) ⬆️
... and 78 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite
olavloite enabled auto-merge (squash) February 10, 2023 14:17
@olavloite
olavloite merged commit f9973f1 into postgresql-dialect Feb 10, 2023
@olavloite
olavloite deleted the timezone-localtime branch February 10, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unknown timezone id: localtime

2 participants