Repository navigation
feat: support force_autocommit - #541
Merged
Merged
Conversation
Add support for the `spanner.force_autocommit` session configuration that can be used to force a connection to use autocommit for all statements. A connection that has activated this configuration option will ignore any transaction statements and execute all statements in autocommit. This option can be used in combination with the `spanner.autocommit_dml_mode` setting to force all DML statements to use Partitioned DML. Insert statements do not support PDML, and if both these two options have been set, PGAdapter will automatically execute insert statements using normal transactions to prevent errors from occurring.
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #541 +/- ##
========================================================
- Coverage 88.39% 88.33% -0.06%
- Complexity 2063 2066 +3
========================================================
Files 122 122
Lines 6771 6783 +12
Branches 949 954 +5
========================================================
+ Hits 5985 5992 +7
- Misses 558 560 +2
- Partials 228 231 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
olavloite
marked this pull request as ready for review
December 9, 2022 20:26
olavloite
requested review from
fenilfadadu,
gauravsnj,
manu2 and
pratickchokhani
December 9, 2022 20:26
pratickchokhani
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
spanner.force_autocommitsession configuration that can be used to force a connection to use autocommit for all statements. A connection that has activated this configuration option will ignore any transaction statements and execute all statements in autocommit. This option can be used in combination with thespanner.autocommit_dml_modesetting to force all DML statements to use Partitioned DML. Insert statements do not support PDML, and if both these two options have been set, PGAdapter will automatically execute insert statements using normal transactions to prevent errors from occurring.go/pgadapter-force_autocommit