Skip to content

feat: support VACUUM as a no-op - #532

Merged
olavloite merged 8 commits into
postgresql-dialectfrom
vacuum-statement
Jan 16, 2023
Merged

olavloite merged 8 commits into
postgresql-dialectfrom
vacuum-statement

Conversation

@olavloite

@olavloite olavloite commented Dec 6, 2022 •

Copy link
Copy Markdown
Collaborator

Support the VACUUM statement as a no-op. Executing a VACUUM statement on PGAdapter is a no-operation, but it will verify that the syntax that is used is valid, and that the tables and columns that are referenced are valid and do exist.

go/pgadapter-vacuum

Support the `VACUUM` statement as a no-op.
@codecov

codecov Bot commented Dec 7, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #532 (7729ca6) into postgresql-dialect (e4c3aa2) will increase coverage by 0.03%.
The diff coverage is 92.70%.

@@                   Coverage Diff                    @@
##             postgresql-dialect     #532      +/-   ##
========================================================
+ Coverage                 88.59%   88.62%   +0.03%     
- Complexity                 2103     2132      +29     
========================================================
  Files                       123      124       +1     
  Lines                      6959     7095     +136     
  Branches                    982     1010      +28     
========================================================
+ Hits                       6165     6288     +123     
- Misses                      562      569       +7     
- Partials                    232      238       +6     
Flag Coverage Δ
all_tests 88.62% <92.70%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/spanner/pgadapter/wireprotocol/QueryMessage.java 100.00% <ø> (ø)
.../spanner/pgadapter/statements/VacuumStatement.java 91.42% <91.42%> (ø)
...panner/pgadapter/statements/BackendConnection.java 93.53% <96.15%> (+0.11%) ⬆️
...oud/spanner/pgadapter/statements/SimpleParser.java 92.29% <100.00%> (+0.05%) ⬆️
...d/spanner/pgadapter/wireprotocol/ParseMessage.java 91.93% <100.00%> (+0.41%) ⬆️
...gle/cloud/spanner/pgadapter/ConnectionHandler.java 86.38% <0.00%> (-0.84%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite
olavloite marked this pull request as ready for review December 8, 2022 16:32
@olavloite
olavloite merged commit 20dc062 into postgresql-dialect Jan 16, 2023
@olavloite
olavloite deleted the vacuum-statement branch January 16, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants