Skip to content

fix: close buffers used by Converter after use - #434

Merged
olavloite merged 5 commits into
postgresql-dialectfrom
close-converter-buffers
Oct 27, 2022
Merged

olavloite merged 5 commits into
postgresql-dialectfrom
close-converter-buffers

Conversation

@olavloite

Copy link
Copy Markdown
Collaborator

Close buffers that are used by the Converter after it is done.

@codecov

codecov Bot commented Oct 26, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #434 (04b49c1) into postgresql-dialect (cf6d007) will decrease coverage by 0.00%.
The diff coverage is 61.53%.

@@                   Coverage Diff                    @@
##             postgresql-dialect     #434      +/-   ##
========================================================
- Coverage                 86.29%   86.29%   -0.01%     
- Complexity                 1913     1914       +1     
========================================================
  Files                       122      122              
  Lines                      6210     6215       +5     
  Branches                    848      849       +1     
========================================================
+ Hits                       5359     5363       +4     
  Misses                      607      607              
- Partials                    244      245       +1     
Flag Coverage Δ
all_tests 86.29% <61.53%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...spanner/pgadapter/wireprotocol/ControlMessage.java 86.53% <58.33%> (-0.36%) ⬇️
...oogle/cloud/spanner/pgadapter/utils/Converter.java 91.30% <100.00%> (+0.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite
olavloite merged commit 4b0b500 into postgresql-dialect Oct 27, 2022
@olavloite
olavloite deleted the close-converter-buffers branch October 27, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant