Repository navigation
fix: allow 'T' in timestamp values in COPY operations - #319
Merged
Merged
Conversation
COPY operations used the TimestampUtils from the PG JDBC driver. This class does not accept timestamp values that contain a 'T' as a separator between the date and time value. Instead, we'll rely on our own Timestamp parser that we already have in place for wire-protocol conversion. Fixes b/240602999
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #319 +/- ##
=====================================================
Coverage ? 83.66%
Complexity ? 1512
=====================================================
Files ? 113
Lines ? 5199
Branches ? 674
=====================================================
Hits ? 4350
Misses ? 636
Partials ? 213
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COPY operations used the
TimestampUtilsfrom the PG JDBC driver. Thisclass does not accept timestamp values that contain a 'T' as a separator
between the date and time value. Instead, we'll rely on our own
Timestamp parser that we already have in place for wire-protocol
conversion.
Fixes b/240602999