Repository navigation
fix: skip bytes in an invalid stream defensively - #241
Merged
Merged
Conversation
PGAdapter should defensively skip bytes if it receives a message that it does not recognize (i.e. the stream has become corrupted). Otherwise, the stream might block if it tries to skip more bytes than are available in the stream, which again could cause the connection to be blocked.
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #241 +/- ##
=====================================================
Coverage ? 80.99%
Complexity ? 1111
=====================================================
Files ? 94
Lines ? 3726
Branches ? 445
=====================================================
Hits ? 3018
Misses ? 546
Partials ? 162
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PGAdapter should defensively skip bytes if it receives a message that it
does not recognize (i.e. the stream has become corrupted). Otherwise,
the stream might block if it tries to skip more bytes than are available
in the stream, which again could cause the connection to be blocked.