Skip to content

Logging: unflake systests #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 3 commits into from
Jul 30, 2018
Merged

Logging: unflake systests #5698

tseaver merged 3 commits into from
Jul 30, 2018

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 27, 2018

Closes #5543.
Closes #5632.
Closes #5692.
Closes #5556.

@tseaver tseaver added testing api: logging Issues related to the Cloud Logging API. labels Jul 27, 2018
@tseaver tseaver requested a review from theacodes July 27, 2018 16:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2018
@tseaver tseaver force-pushed the 5543-5632-5692-5556-logging-unflake-systests branch from 4ded77d to 1a779cf Compare July 27, 2018 17:18
@tseaver
Copy link
Contributor Author

tseaver commented Jul 30, 2018

Merging w/o review as this is a testing-only change, and the tests pass.

@tseaver tseaver merged commit 6bc1d69 into master Jul 30, 2018
@tseaver tseaver deleted the 5543-5632-5692-5556-logging-unflake-systests branch July 30, 2018 17:49
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver
Logging: unflake systests (#5698)
d2ce0b3 
* Harden 'test_list_metrics' against concurrent CI runs.

Closes #5543.

* Harden 'test_list_sinks' against concurrent CI runs.

Closes #5692.

* Harden 'test_log_handler_async' against concurrent CI runs.

Use unique ID for handler, and therefore the underlying back-end log.

Closes #5632.
Closes #5556.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theacodes theacodes Awaiting requested review from theacodes

Assignees

No one assigned

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tseaver @googlebot