Repository navigation
feat(gke): Unify H4D blueprint with dynamic consumption options - #6348
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the GKE H4D blueprint to provide a flexible and unified approach to resource consumption. By standardizing configuration across different node pool types, it simplifies the deployment process for various HPC workload requirements while ensuring compatibility with GKE's native autoscaling and placement policies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the GKE H4D blueprint to support multiple consumption models, such as Specific Reservation, DWS Flex Start, Spot, and On-Demand, and introduces a sample batch job for testing DWS Flex Start. The README has been extensively updated with detailed setup, execution, and cleanup instructions. Review feedback suggests removing the 'git checkout main' step from the README to prevent users from switching away from their current branch, and adding a clarifying note that Option 1 requires manually configuring the reservation name and static node count to avoid deployment failures.
f41749b to
eef4d18
Compare
eef4d18 to
e9180db
Compare
- Support unified consumption models in GKE H4D (Specific Reservation, DWS Flex Start, DWS Flex Start + Queued Provisioning, Spot, and On-Demand) - Configure placement_policy with COMPACT across static node pool options (Reservation, Spot, On-Demand) - Add DWS Flex Start batch test job and update README documentation with deployment and workload execution instructions - Add CPU DWS Kueue queue template and wire kueue_configuration_path for Option 3 - Clean up Cloud Build daily test configuration to leverage dynamic blueprint variables instead of sed manipulation
e9180db to
3dcd797
Compare
3a3d113
into
GoogleCloudPlatform:develop
…leCloudPlatform#6348) Co-authored-by: Ishita Chail <ishitachail@google.com>
This PR standardizes the GKE H4D blueprint to support unified consumption options:
Compact Placement Across Consumption Models
Compact placement is configured directly under Options 1, 4, and 5 (
placement_policy: { type: COMPACT }) ingke-h4d-deployment.yaml:placement_policyis left unconfigured (null) for Options 2 and 3 in the deployment template.Workload Execution & DWS Flex Start Test Job
test-job-flex.yaml) fromgke-consumption-optionstoexamples/gke-h4d/. The job defines matching node selectors (cloud.google.com/gke-flex-start: "true") and tolerations (node-type=h4d:NoSchedule) required to trigger GKE Cluster Autoscaler scale-up from 0.examples/gke-h4d/README.mdwith complete prerequisites, deployment instructions, step-by-step lifecycle monitoring for DWS scale-up/scale-down, and a clarification note that the Kubeflow MPI Operator requires static node pools (Options 1, 4, or 5).Cloud Build Daily Test Cleanup
gke-h4d-onspot.yamlbuild definition to eliminate fragilesedblueprint replacements. It now leverages the native blueprint variables and safely overridesremote-nodeparameters.Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.