[ishitachail]

[Telemetry] Adding hpc-toolkit-dev-2 to testProjects

Overview

The integration and daily test suites were migrated to run in hpc-toolkit-dev-2. Previously, only hpc-toolkit-dev was recognized in testProjects, causing test runs in hpc-toolkit-dev-2 to report CLUSTER_TOOLKIT_IS_TEST_DATA = "false" and skew production telemetry metrics.

Changes

• Collector: Added hpc-toolkit-dev-2 to testProjects in pkg/telemetry/collector.go to ensure blueprints running in the new daily test project are identified with CLUSTER_TOOLKIT_IS_TEST_DATA = "true".
• Tests: Added a unit test case for hpc-toolkit-dev-2 in TestGetIsTestData (pkg/telemetry/collector_test.go) to validate test project detection.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the telemetry collection logic to correctly identify 'hpc-toolkit-dev-2' as a test environment. By adding this project to the test projects list, the system ensures that telemetry data generated from these test runs is properly flagged, preventing the skewing of production metrics.

Highlights

• Telemetry Configuration: Added 'hpc-toolkit-dev-2' to the list of recognized test projects in the telemetry collector.
• Test Coverage: Included a new unit test case to verify that 'hpc-toolkit-dev-2' is correctly identified as a test project.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new test project ID, "hpc-toolkit-dev-2", to the list of test projects in pkg/telemetry/collector.go and includes a corresponding unit test case in pkg/telemetry/collector_test.go to verify its identification. There are no review comments, and I have no feedback to provide.