Enable DeserializationFeature.READ_ENUMS_USING_TO_STRING by default (3.0) - #4566
Conversation
|
Re-running CI because of Fuzzer failure (was nearly impossible to read log, due to its enormous volume) |
|
I do not recall seeing that error, but I also haven't been paying attention to Fuzzer action. I think I should just go ahead and disable it, seems to have little value and I think OSS-Fuzz runs their generation elsewhere anyway. Oddly enough, it runs only for... PRs? And one for |
…SING_TO_STRING-default-for-Jackson-3
|
@pjfanning pointed the obvious: Jackson package name means OSS-Fuzz code, built against 2.x, won't work. So this should now be merged, fixed. |
|
Will review this and #4567 later today, get merged. Good stuff! |
DeserializationFeature.READ_ENUMS_USING_TO_STRING by defaultDeserializationFeature.READ_ENUMS_USING_TO_STRING by default (3.0)
|
Will update JSTEP-2 Wiki accordingly. cc. @cowtowncoder |
|
I did some updates but may have missed something so appreciate your help @JooHyukKim. |
I checked and everything is there 👍🏼 |
|
Hello, looking through JSTEP2 to understand the changes to jackson defaults I noticed that this and the sibling feature don't have the rationale mentioned anywhere. What's the rationale behind this changed default? |
|
@Karl255 I think it was requested by multiple users -- but in general seemed like the way to go as default handling for "vanilla" Enums is the same either way ( |
|
Thanks @Karl255 ! I’ll think I accidentally pointed JStep doc and issue to the wrong place. Good if u could hep as well! Thanks |
|
I wasn't able to find anything related to this myself, which is why I asked in the first place. I'll also mention that this creates an issue with Java's built-in ChronoUnit enum, as the toString() returns for example "Minutes" instead of "MINUTES" as name() does. It's something that we have to handle in our codebase now, though we probably shouldn't be storing Java's enums in the first place 😄 |
|
Ah, too bad about |

Implements JSTEP-2 > DeserializationFeature