fix: resolve "Failed to get session title" error in packaged macOS app - #33
Merged
Conversation
After packaging for macOS, the app would fail with "Failed to get session title"
error when creating new sessions, preventing normal operation.
The issue was caused by accessing Electron's `app.isPackaged` property at module
load time, which fails in the packaged environment:
- `export const claudeCodePath = getClaudeCodePath()` was called during module initialization
- `app.getPath("userData")` was called at module level in ipc-handlers.ts
- `app.on()` event handlers were registered at module level in main.ts
1. **util.ts**: Delay `getClaudeCodePath()` call to runtime within
`generateSessionTitle()` function instead of module-level constant
2. **runner.ts**: Use `getClaudeCodePath()` function call instead of importing constant
3. **ipc-handlers.ts**: Delay sessions initialization with `initializeSessions()` function
4. **main.ts**: Move event handler registration inside `app.on("ready")` callback
5. Add comprehensive error handling with fallback to simple title generation
- Update README.md and README_ZH.md to correct build commands
(dist:mac-arm64 and dist:mac-x64 instead of non-existent dist:mac)
Co-Authored-By: tian.r.king <tian.r.king@gmail.com>
Contributor
Author
|
hola ping @wksantiago @Pactortester |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After packaging for macOS, the app would fail with "Failed to get session title" error when creating new sessions, preventing normal operation.
The issue was caused by accessing Electron's
app.isPackagedproperty at module load time, which fails in the packaged environment:export const claudeCodePath = getClaudeCodePath()was called during module initializationapp.getPath("userData")was called at module level in ipc-handlers.tsapp.on()event handlers were registered at module level in main.tsgetClaudeCodePath()call to runtime withingenerateSessionTitle()function instead of module-level constantgetClaudeCodePath()function call instead of importing constantinitializeSessions()functionapp.on("ready")callback