Extending catalogs with missing messages April 9th#651
Merged
tdonohue merged 1 commit intoDSpace:masterfrom Apr 17, 2020
Merged
Extending catalogs with missing messages April 9th#651tdonohue merged 1 commit intoDSpace:masterfrom
tdonohue merged 1 commit intoDSpace:masterfrom
Conversation
tdonohue
approved these changes
Apr 17, 2020
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 This looks fine to me. Even though it's large, it's just updating language packs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Execution of the i18n sync script to bring the catalogs up to date with all recently added messages in en.json5
Instructions for Reviewers
Because of the sheer size of this PR, I'm not comfortable merging this one without another review, even though it's i18n related.