Skip to content

Conversation

@junekhan
Copy link
Contributor

This PR fixes #764

@junekhan junekhan force-pushed the bugfix/CORS-headers branch from e07446b to 047e9ff Compare February 21, 2024 05:55
@witcherofthorns
Copy link
Contributor

Great! But, unfortunately, the "Access-Control-Allow-Origin" header does not appear in the response, although I see that it is placed in http_response.h, this is the last problem that remains related to CORS

Crow log:

[DEBUG] [http_response]: add_headerAccess-Control-Allow-Origin | http://localhost:8080
[DEBUG] [http_response]: add_headerAccess-Control-Allow-Methods | *
[DEBUG] [http_response]: add_headerAccess-Control-Allow-Headers | Accept, Origin, Content-Type, Authorization
[DEBUG] [http_response]: add_headerAccess-Control-Max-Age | 5
[DEBUG] [http_response]: add_headerAccess-Control-Allow-Credentials | true

Frontend server-response:

HTTP/1.1 204 No Content
Access-Control-Max-Age: 5
Access-Control-Allow-Headers: Accept, Origin, Content-Type, Authorization
Access-Control-Allow-Methods: *
Access-Control-Allow-Credentials: true

In any case, thank you very much! 👏 I somehow didn’t think to look at http_connection.h and see that there is need_to_call_after_handlers_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CORS problem in 1.1.0

3 participants