Skip to content

splitted crow features into two options #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gittiver merged 1 commit into from
Jun 3, 2024
Merged

splitted crow features into two options #770

gittiver merged 1 commit into from
Jun 3, 2024

Conversation

@gittiver
Copy link
Member

@gittiver gittiver commented Feb 20, 2024

No description provided.

@gittiver gittiver linked an issue Feb 21, 2024 that may be closed by this pull request
The Option for features (ssl and compression) is shown as boolean by cmake but uses as list of strings #737
Closed
@gittiver gittiver force-pushed the split-crow-feature-options branch 3 times, most recently from 120ecd7 to d57a913 Compare February 21, 2024 21:13
@gittiver gittiver marked this pull request as ready for review February 21, 2024 21:14
@gittiver gittiver added the bug Something isn't working label Feb 21, 2024
mrozigor
mrozigor reviewed Mar 8, 2024
View reviewed changes
@gittiver gittiver marked this pull request as draft March 10, 2024 12:55
@gittiver
Copy link
Member Author

gittiver commented Mar 10, 2024

moved back to draft, as options are incompatible and therefore also there documentation has to be adapted.

@gittiver gittiver force-pushed the split-crow-feature-options branch 3 times, most recently from 4457071 to fb370ab Compare May 7, 2024 21:34
@gittiver gittiver force-pushed the split-crow-feature-options branch 2 times, most recently from 60ba5de to 0b91b17 Compare May 29, 2024 10:44
@gittiver gittiver force-pushed the split-crow-feature-options branch from 0b91b17 to dce9d54 Compare May 30, 2024 21:31
@gittiver gittiver marked this pull request as ready for review May 30, 2024 21:37
@gittiver
Copy link
Member Author

gittiver commented May 30, 2024

added corrections in docs

@gittiver gittiver merged commit 90579e9 into master Jun 3, 2024
@gittiver gittiver deleted the split-crow-feature-options branch July 26, 2024 08:28
@BrewTestBot BrewTestBot mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrozigor mrozigor mrozigor approved these changes

@dranikpg dranikpg Awaiting requested review from dranikpg

@The-EDev The-EDev Awaiting requested review from The-EDev

@luca-schlecker luca-schlecker Awaiting requested review from luca-schlecker

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Option for features (ssl and compression) is shown as boolean by cmake but uses as list of strings

3 participants

@gittiver @mrozigor