Fix faulty https redirection. #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crow would redirect to https if ssl is enabled, even if no ssl is being actively used. Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
Seems like a leftover from when https was first implemented. Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
The-EDev
previously approved these changes
Nov 22, 2021
Member
There was a problem hiding this comment.
Everything seems good. Thanks a lot, not just for the work but because this PR opens the door for another improvement I was thinking of, basically changing the first log to add http:// or https:// along with the host and port.
Edit: I added the change to this PR, I hope you don't mind (let me know if you do, I'll remove it immediately!)
The-EDev
approved these changes
Nov 22, 2021
Collaborator
Author
|
Nope, I don't mind. 🚀 |
Member
|
Great!, I'll merge once the tests have finished :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luca Schlecker luca.schlecker@hotmail.com
If SSL is enabled, but not used, redirection breaks.
Crow/include/crow/http_connection.h
Lines 393 to 397 in 0e15963
If SSL is enabled,
response::redirectwill always redirect tohttps://leading to broken links.This PR fixes this by adding a
bool ssl_used() constfunction to the App which can be used to determine whether or not SSL is being actively used. Based on that the right protocol will be selected.The second commit removes unneeded SSL Code which I guess is a leftover from when https support was first implemented.